Skip to content

Trigger url change #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2025
Merged

Trigger url change #702

merged 4 commits into from
Sep 21, 2025

Conversation

dharmesh-hemaram
Copy link
Member

This pull request introduces support for triggering configuration when the URL changes without a full page reload (useful for Single Page Applications), and adds new internationalization strings for scheduling features and userscript management across multiple languages. It also includes corresponding logic updates to handle the new URL change trigger and expands validation messages for scheduling fields.

Feature Enhancements

  • Added support for triggering configuration when the URL changes without a page reload by importing watch-url-change in background/index.ts and updating the config loading logic in content_scripts/index.ts to check the new triggerUrlChange property. [1] [2]

Internationalization Updates

  • Added new i18n strings for scheduling (title, info, date, time, repeat, success message, and validation errors) in Arabic, German, Spanish, Finnish, and English locale files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
  • Added new i18n strings for userscript management (add, remove, and related prompts) in all supported languages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Configuration UI Improvements

  • Added new UI labels and hints for the "Trigger on URL Change" option in all locales, explaining its effect for SPA scenarios. [1] [2] [3] [4] [5]

Minor Localization Updates

  • Added translations for "minute" in all supported languages. [1] [2] [3] [4]

Cleanup

  • Removed unused userscript management strings from the English locale to streamline the i18n file.

@dharmesh-hemaram
feat: Add user script management and URL change trigger functionality
fd5ec55 
- Introduced user script removal confirmation messages in multiple languages.
- Added configuration options for triggering actions on URL changes, enhancing support for single-page applications (SPAs).
- Updated configuration modal to include a switch for enabling/disabling URL change triggers.
- Enhanced documentation to explain the new URL change trigger feature, including usage scenarios and best practices.
- Updated localization files for various languages to reflect new features and messages.
@dharmesh-hemaram
fix(locales): correct translation for "min" in Italian and Dutch
451f5d9
@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 06:27
Copilot
Copilot AI reviewed Sep 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds URL change triggering support for Single Page Applications (SPAs) and expands internationalization coverage for scheduling and userscript management features.

  • Implements URL change detection to automatically trigger configurations when URLs change without page reloads
  • Adds comprehensive scheduling-related i18n strings with validation messages across all supported languages
  • Includes new userscript management translations and removes unused English userscript strings

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
site/src/content/docs/configuration/config-settings.mdx Documents the new "Trigger on URL change" feature with usage examples and best practices
packages/acf/common/src/lib/model/IConfiguration.ts Adds triggerUrlChange optional boolean property to configuration interface and default config
apps/acf-options-page/src/modal/config-settings.modal.tsx Implements UI toggle for the new URL change trigger setting with hint text
apps/acf-extension/src/content_scripts/index.ts Updates config loading logic to check triggerUrlChange property for URL_CHANGE load type
apps/acf-extension/src/background/index.ts Imports URL change watching functionality
apps/acf-i18n/src/locales/*/web.json Adds scheduling, userscript management, and URL change trigger translations across all 20+ locale files

@nx-cloud
Copy link

nx-cloud bot commented Sep 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 22e84c9

Command Status Duration Result
nx affected --target=typecheck --parallel=3 --v... ✅ Succeeded 1s View ↗
nx affected --target=test --parallel=3 --verbos... ✅ Succeeded 1s View ↗
nx affected --target=lint --parallel=3 --verbos... ✅ Succeeded 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-21 06:40:25 UTC

@codacy-production
Copy link

codacy-production bot commented Sep 21, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b1152331 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b115233) Report Missing Report Missing Report Missing
Head commit (22e84c9) 793 86 10.84%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#702) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

dharmesh-hemaram and others added 2 commits September 21, 2025 12:08
@dharmesh-hemaram @Copilot
Update apps/acf-i18n/src/locales/zh_TW/web.json
8cf9f2b 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
@dharmesh-hemaram @Copilot
Update apps/acf-i18n/src/locales/ko/web.json
22e84c9 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dharmesh <dharmesh.hemaram@gmail.com>
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@dharmesh-hemaram dharmesh-hemaram merged commit 5825245 into main Sep 21, 2025
10 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the trigger-url-change branch September 21, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

Auto Clicker - AutoFill
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dharmesh-hemaram